forum

n0ahg wrote:Agreed, something weird going on. I even commented on a change made to my DummyDevice 21 days ago and no response. I was happy with the openness but now they seem to have swung the other way.

Thanks for the contributions.

I think it is because JS people are on vacation

@islipfd19 good job! why not to make a fork on github and make a pull request?

We will have a look on your both modules and possibly merge them into main branch.

Ok, I already have an account with Github. I'll try to do it this in the coming days.

Any comments or help with the other modules I've provided would greatly be appreciated.

PoltoS wrote:@islipfd19 good job! why not to make a fork on github and make a pull request?

We will have a look on your both modules and possibly merge them into main branch.

@PoltoS

I've forked the project and added the three modules to my fork.

islipfd19 wrote:

PoltoS wrote:@islipfd19 good job! why not to make a fork on github and make a pull request?

We will have a look on your both modules and possibly merge them into main branch.

@PoltoS

I've forked the project and added the three modules to my fork.

Now you need to create a pull request, see steps 5 and 6 in the last section here https://github.com/Z-Wave-Me/home-autom ... stallation

n0ahg wrote:

islipfd19 wrote:

PoltoS wrote:@islipfd19 good job! why not to make a fork on github and make a pull request?

We will have a look on your both modules and possibly merge them into main branch.

@PoltoS

I've forked the project and added the three modules to my fork.

Now you need to create a pull request, see steps 5 and 6 in the last section here https://github.com/Z-Wave-Me/home-autom ... stallation

Thanks! Just did it. I created the pull request for the bleeding edge branch. It should be in this one, right? Or should I be adding it to the master branch?

I have done it on the develop branch in the past. Not sure if all the changes in bleeding-edge will make it in to master but as you only add files and don't modify other files you should be fine and they should be able to merge your changes. Still getting my head around git and github.

n0ahg wrote:I have done it on the develop branch in the past. Not sure if all the changes in bleeding-edge will make it in to master but as you only add files and don't modify other files you should be fine and they should be able to merge your changes. Still getting my head around git and github.

Gotcha, thanks!

Loving this module..

If I can suggest an Option to disable the turning off the switch on sunrise (maybe have a Disable in the drop down list might be a good way to support this..

Thanks for your hard work..

It's most probably possible to do this. Before I put some effort into it, I'd like to understand why you would like this option and the scenario or scenarios you use it in? Knowing this will help me improve it.