Reporting bugs

Discussion about Z-Uno product. Visit http://z-uno.z-wave.me for more details.
Post Reply
User avatar
PoltoS
Posts: 4334
Joined: 26 Jan 2011 19:36

Reporting bugs

Post by PoltoS » 29 Sep 2018 10:09

When reporting bugs please make sure to provide us minimal information about the issue you are facing. You can post issues here on the forum in a separate thread for each bug or on github

Here is the template for your bug report:

Please fill your bug report here

More info:
  • Z-Uno bootloader version:2.1.x (release version or test-ucxx?)
  • Security:none/S2/S0
  • Frequency:EU/US/RU/ANZ-BR/IN/CN/JP/KR/TW
  • Device included:yes/no
  • Device included securely by controller:yes/no
  • Controller:RaZberry/Z-Way/Fibaro HC2/Fibaro HCL/Vera/other
Connected peripherals:
Please add here a description, photo and/or schematics of your peripherals

Code:
If you can minimize your code to still reproduce the bug, please do it before reporting

Code: Select all

your code here
Compiler log:
Please paster the compiler output

Code: Select all

----------------------------------------------------------
                     FIRMWARE DATA
----------------------------------------------------------
        REVISION:02.15
        Z-WAVE FREQUENCY:RU

... (more lines up to)

        CHIP:1546 REVISION:4
Debug output:
Connect to UART0, enable Logging->UART0, open logging monitor and dump the output. Should look like:

Code: Select all

0000:00 03
0000:00 00
0010:A0 00
0011:A0 00
0012:A0 00

bastibart
Posts: 5
Joined: 12 Dec 2018 16:37

SoftwareSerial::read

Post by bastibart » 15 Dec 2018 15:54

Dear developers

I hope this is the right place to post this feedback. If not please move it accordingly.

The Arduino implementation of SoftwareSerial::read() returns -1 if the buffer is empty, whereas the z-uno implementation returns 0.
I spent quite some time debugging before noticing this deviation from the expected behaviour.

One could argue 'use .available()' but why should I have to. It adds an extra line of code.
Also - z-uno's implentation of read() does not allow to distiguish between the value 0 and an empty buffer.

I would appreciate read() to be changed to match the standard impletation.

EDIT:
SoftwareSerial::read() will read past the end pointer of the buffer and wrap around to previously read data.
That is not very well behaved, is it?

Thanks
Sebastian

Post Reply